Closed
Conversation
- added simple test, with no assert, for file identification; and - added similar for stream identification which demonstrates hang.
- fixed termination condition in `blocking_read`.
Bring in a CSV reader to consume the FIDO output and make various assertions about the result's validity.
ross-spencer
force-pushed
the
dev/develop-fido-test-w-pytest
branch
from
f5adcce to
3b9e73f
Compare
Member
|
Closed as contained in #226 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
===========================================
+ Coverage 23.42% 34.00% +10.58%
===========================================
Files 11 11
Lines 1490 1491 +1
===========================================
+ Hits 349 507 +158
+ Misses 1141 984 -157 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstrating use of
pytestwith Carl's updates in #190Connected to #189